Skip to content

Issues-79: fix each partial invoke #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sergeevik wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Issues-79: fix each partial invoke #80

sergeevik wants to merge 1 commit into from
+28 −5

Conversation

@sergeevik
Copy link

@sergeevik sergeevik commented Dec 15, 2025

In js array may be object with key as index
some another fix:

  • remove generic in string method. replace with toString
  • applyInner check not null before use in matcher
  • check ? when arg type is operator by toString.equals (? is char in value)
  • 2 test for each partial expression

@sergeevik
Issues-79: fix each partial invoke
6690975 
In js array may be object with key as index
some another fix:
- remove generic in string method. replace with toString
- applyInner check not null before use in matcher
- check ? when arg type is operator by toString.equals (? is char in value)
- 2 test for each partial expression
@sergeevik sergeevik mentioned this pull request Dec 15, 2025
Open
sergeevik
sergeevik commented Dec 16, 2025
View reviewed changes
src/main/java/com/dashjoin/jsonata/Jsonata.java
lhs = new HashMap();
for (int i = 0; i < tempLhs.size(); i++) {
((HashMap) lhs).put(i, tempLhs.get(i));
}
Copy link
Author

@sergeevik sergeevik Dec 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better:

var lhsNewMap =  new HashMap();
var lhsOldList = (List)lhs;
for (int i = 0; i < lhsOldList.size(); i++) {
  lhsNewMap.put(i, tempLhs.get(i));
}
lhs = lhsNewMap;

@uw4 uw4 self-assigned this Dec 18, 2025
@uw4 uw4 requested a review from aeberhart December 18, 2025 15:57
uw4
uw4 reviewed Dec 18, 2025
View reviewed changes
Copy link
Contributor

@uw4 uw4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks + good catch!
We're reviewing this behavior of $each with list as input -
we want to clarify this with the original Jsonata maintainers, might be as well be a glitch in the original impl

@sergeevik
Copy link
Author

sergeevik commented Jan 23, 2026 •
edited
Loading

find some another bug caused by this fix.
fix realisation wrapped all partial expression. but need only to each (caught bug with $map function)

@uw4 @aeberhart any updates about for this bug?

memory pill for me:

json:

{
  "buildings": {
    "home": {
      "address": "home address",
      "period": "11 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "home widget"
          }
        }
      }
    },
    "work": {
      "address": "work address",
      "presentation": {
        "first": {
          "widget": {
            "data": "work widget"
          }
        }
      }
    },
    "vacancy": {
      "address": "vacancy address",
      "period": "1 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "vacancy widget"
          }
        }
      }
    },
    "old": {
      "address": "old address",
      "period": "2 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "old widget"
          }
        }
      }
    },
    "operation": {
      "address": "operation address",
      "period": "3 month on 12",
      "presentation": {
        "first": {
          "widget": {
            "data": "operation widget"
          }
        }
      }
    }
  }
}

and expression

$sift($.buildings, function($v, $k) { $k ~> /o/ and $v.presentation.*.widget})
                    ~> $each(?, function($v, $key) {{ $key: $sift($v.presentation, function($v, $k){ $v.widget }) }})
                    ~> $map(?, function($v){($v.*)})

not fork after this fix and not coverage by tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uw4 uw4 uw4 left review comments

@aeberhart aeberhart Awaiting requested review from aeberhart

Assignees

@uw4 uw4

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergeevik @uw4